From 95892f31e65511987cc2c485531c1b9ba3d6a626 Mon Sep 17 00:00:00 2001 From: "Anssi \"Miffyli\" Kanervisto" Date: Thu, 15 Oct 2020 02:27:22 +0300 Subject: [PATCH] Update PR template --- .github/PULL_REQUEST_TEMPLATE.md | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 2b35d61..197aabf 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,13 +1,11 @@ - + ## Description - + -## Motivation and Context - - - -- [ ] I have raised an issue to propose this change ([required](https://github.com/DLR-RM/stable-baselines3/blob/master/CONTRIBUTING.md) for new features and bug fixes) +## Context + +- [ ] I have raised an issue to propose this change ([required](https://github.com/Stable-Baselines-Team/stable-baselines3-contrib/blob/master/CONTRIBUTING.md)) ## Types of changes @@ -19,11 +17,13 @@ ## Checklist: -- [ ] I've read the [CONTRIBUTION](https://github.com/DLR-RM/stable-baselines3/blob/master/CONTRIBUTING.md) guide (**required**) -- [ ] I have updated the changelog accordingly (**required**). -- [ ] My change requires a change to the documentation. +- [ ] I've read the [CONTRIBUTION](https://github.com/Stable-Baselines-Team/stable-baselines3-contrib/blob/master/CONTRIBUTING.md) guide (**required**) +- [ ] The functionality/performance matches that of the source (**required** for new training algorithms or training-related features). - [ ] I have updated the tests accordingly (*required for a bug fix or a new feature*). +- [ ] I have included an example of using the feature (*required for new features*). +- [ ] I have included baseline results (**required** for new training algorithms or training-related features). - [ ] I have updated the documentation accordingly. +- [ ] I have updated the changelog accordingly (**required**). - [ ] I have reformatted the code using `make format` (**required**) - [ ] I have checked the codestyle using `make check-codestyle` and `make lint` (**required**) - [ ] I have ensured `make pytest` and `make type` both pass. (**required**)