From 61bfdbc00a6d5e09b401e29b2190aa7a2079d8e8 Mon Sep 17 00:00:00 2001 From: Antonin RAFFIN Date: Wed, 5 May 2021 11:42:10 +0200 Subject: [PATCH] Fix unused code (#28) * Fix unused code * Update changelog * Update SB3 dependency --- .github/workflows/ci.yml | 2 +- docs/misc/changelog.rst | 21 +++++++++++++++++++++ sb3_contrib/tqc/tqc.py | 2 -- sb3_contrib/version.txt | 2 +- setup.py | 2 +- 5 files changed, 24 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1021c18..90fa2ae 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -28,7 +28,7 @@ jobs: run: | python -m pip install --upgrade pip # cpu version of pytorch - pip install torch==1.8.0+cpu -f https://download.pytorch.org/whl/torch_stable.html + pip install torch==1.8.1+cpu -f https://download.pytorch.org/whl/torch_stable.html # Install dependencies for docs and tests pip install stable_baselines3[extra,tests,docs] # Install master version diff --git a/docs/misc/changelog.rst b/docs/misc/changelog.rst index f302bf0..86f87d6 100644 --- a/docs/misc/changelog.rst +++ b/docs/misc/changelog.rst @@ -3,6 +3,27 @@ Changelog ========== +Release 1.1.0a5 (WIP) +------------------------------- + +Breaking Changes: +^^^^^^^^^^^^^^^^^ + +Bug Fixes: +^^^^^^^^^^ +- Removed unused code in ``TQC`` + +Deprecations: +^^^^^^^^^^^^^ + +Others: +^^^^^^^ +- SB3 docs and tests dependencies are no longer required for installing SB3 contrib + +Documentation: +^^^^^^^^^^^^^^ + + Release 1.0 (2021-03-17) ------------------------------- diff --git a/sb3_contrib/tqc/tqc.py b/sb3_contrib/tqc/tqc.py index 44eb555..815916d 100644 --- a/sb3_contrib/tqc/tqc.py +++ b/sb3_contrib/tqc/tqc.py @@ -132,8 +132,6 @@ class TQC(OffPolicyAlgorithm): def _setup_model(self) -> None: super(TQC, self)._setup_model() self._create_aliases() - self.replay_buffer.actor = self.actor - self.replay_buffer.ent_coef = 0.0 # Target entropy is used when learning the entropy coefficient if self.target_entropy == "auto": diff --git a/sb3_contrib/version.txt b/sb3_contrib/version.txt index d3827e7..c84ce18 100644 --- a/sb3_contrib/version.txt +++ b/sb3_contrib/version.txt @@ -1 +1 @@ -1.0 +1.1.0a5 diff --git a/setup.py b/setup.py index d82add2..a78cfb4 100644 --- a/setup.py +++ b/setup.py @@ -62,7 +62,7 @@ setup( packages=[package for package in find_packages() if package.startswith("sb3_contrib")], package_data={"sb3_contrib": ["py.typed", "version.txt"]}, install_requires=[ - "stable_baselines3[tests,docs]>=1.0", + "stable_baselines3>=1.0", ], description="Contrib package of Stable Baselines3, experimental code.", author="Antonin Raffin",